DC-207 Add: Run Playwright/Pa11y tests in CI; fix: example spec#90
Merged
DC-207 Add: Run Playwright/Pa11y tests in CI; fix: example spec#90
Conversation
553b7e2 to
c29d09f
Compare
jamesmblair
previously requested changes
Mar 17, 2026
Member
jamesmblair
left a comment
There was a problem hiding this comment.
Overall good - just a couple of minor things.
84b4933 to
5d4a54e
Compare
632ff0e to
4f548e2
Compare
27314d3 to
785b7bc
Compare
ShaynaCummings
approved these changes
Mar 18, 2026
c0506fc to
7d4ecf8
Compare
Talked about the changes in standup; they've been addressed and Shayna approved the latest changes
necampanini
pushed a commit
that referenced
this pull request
Apr 14, 2026
* DC-207 Add: Run Playwright tests in CI; fix: example spec * DC-207 Fix: Wait for uswds-loading class to be gone * DC-207 Update: Update command, set GITHUB_TOKEN read to permission read * DC-207 Fix: double-dash being consumed by playwright * DC-207 Add: Pa11y runs on CI * DC-207 Add: Set PUPPETEER_EXECUTABLE_PATH to indicate chrome path * DC-207 Update: Add timeout and install Chrome via puppeteer install * DC-207 Add: Puppeteer as a dependency * DC-207 Update: command usage in CI script related to pa11y * DC-207 Update: command to be less redundent; make clear it runs on all browsers * DC-207 Update: Puppeteer version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following: