Skip to content

DC-207 Add: Run Playwright/Pa11y tests in CI; fix: example spec#90

Merged
noxmwalsh merged 11 commits intomainfrom
chore/DC-207-fix-e2e-tests
Mar 18, 2026
Merged

DC-207 Add: Run Playwright/Pa11y tests in CI; fix: example spec#90
noxmwalsh merged 11 commits intomainfrom
chore/DC-207-fix-e2e-tests

Conversation

@noxmwalsh
Copy link
Copy Markdown
Contributor

@noxmwalsh noxmwalsh commented Mar 17, 2026

This PR adds the following:

  • Run Playwright/Pa11y tests in CI.

Comment thread .github/workflows/playwright-e2e.yaml Fixed
@noxmwalsh noxmwalsh force-pushed the chore/DC-207-fix-e2e-tests branch from 553b7e2 to c29d09f Compare March 17, 2026 18:12
Copy link
Copy Markdown
Member

@jamesmblair jamesmblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good - just a couple of minor things.

Comment thread .github/workflows/playwright-e2e.yaml
Comment thread .github/workflows/playwright-e2e.yaml Fixed
Comment thread package.json Outdated
@noxmwalsh noxmwalsh force-pushed the chore/DC-207-fix-e2e-tests branch from 84b4933 to 5d4a54e Compare March 17, 2026 18:22
@noxmwalsh noxmwalsh force-pushed the chore/DC-207-fix-e2e-tests branch from 632ff0e to 4f548e2 Compare March 17, 2026 20:12
@noxmwalsh noxmwalsh changed the title DC-207 Add: Run Playwright tests in CI; fix: example spec DC-207 Add: Run Playwright/Pa11y tests in CI; fix: example spec Mar 17, 2026
@noxmwalsh noxmwalsh force-pushed the chore/DC-207-fix-e2e-tests branch from 27314d3 to 785b7bc Compare March 17, 2026 21:57
@noxmwalsh noxmwalsh self-assigned this Mar 18, 2026
@noxmwalsh noxmwalsh force-pushed the chore/DC-207-fix-e2e-tests branch from c0506fc to 7d4ecf8 Compare March 18, 2026 21:26
@noxmwalsh noxmwalsh dismissed jamesmblair’s stale review March 18, 2026 21:49

Talked about the changes in standup; they've been addressed and Shayna approved the latest changes

@noxmwalsh noxmwalsh merged commit 0542246 into main Mar 18, 2026
16 checks passed
@noxmwalsh noxmwalsh deleted the chore/DC-207-fix-e2e-tests branch March 18, 2026 21:49
necampanini pushed a commit that referenced this pull request Apr 14, 2026
* DC-207 Add: Run Playwright tests in CI; fix: example spec
* DC-207 Fix: Wait for uswds-loading class to be gone
* DC-207 Update: Update command, set GITHUB_TOKEN read to permission read
* DC-207 Fix: double-dash being consumed by playwright
* DC-207 Add: Pa11y runs on CI
* DC-207 Add: Set PUPPETEER_EXECUTABLE_PATH to indicate chrome path
* DC-207 Update: Add timeout and install Chrome via puppeteer install
* DC-207 Add: Puppeteer as a dependency
* DC-207 Update: command usage in CI script related to pa11y
* DC-207 Update: command to be less redundent; make clear it runs on all browsers
* DC-207 Update: Puppeteer version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants